Guard null model fields - fix and tests #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rycochet
reviewed
Sep 15, 2017
| } | ||
| if (Number.isInteger(model.tl.row) && Number.isInteger(model.tl.col) && Number.isInteger(model.br.row) && Number.isInteger(model.br.col)) { | ||
| if (model.tl && Number.isInteger(model.tl.row) && Number.isInteger(model.tl.col) && Number.isInteger(model.br.row) && Number.isInteger(model.br.col)) { |
There was a problem hiding this comment.
Is it worth adding a test for model.br too? Obviously I don't know if it's possible for it to be null or not, but the code doesn't give any indication either way.
There was a problem hiding this comment.
Great point. I went ahead and added a br guard and test. I should have done that originally.
There was a problem hiding this comment.
I started with the tl guard because I was testing with model = {}, which threw an error on that conditional. I didn't have the time to debug everything enough to figure out where model was coming from and why its picture was null, so I'm as in the dark about whether or not br can be null without a null tl as you are. It doesn't hurt, so there's no reason not to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with the
reconcilemethod ofTwoCellAnchorXform. I can't provide the spreadsheet to give you a working demo of the issue, but I did find the problem and built a unit test to display the issue. Basically,model.picturemight be null, which throws an error. Once I added the guards, I was able to load the workbook as usual.