Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to scale time-of-flight in mcxdettime.m using unitinmm #83

Closed
fangq opened this issue Nov 19, 2019 · 0 comments
Closed

Need to scale time-of-flight in mcxdettime.m using unitinmm #83

fangq opened this issue Nov 19, 2019 · 0 comments

Comments

@fangq
Copy link
Owner

fangq commented Nov 19, 2019

this bug was reported by Petein Max in the below mailing list thread

https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/mcx-users/WPAOLq53qeY/h2vdyOxoBAAJ

-------- Forwarded Message --------
Subject: [mcx-users] Concerning cfg.unitinmm feature
Date: Tue, 19 Nov 2019 08:39:20 -0800 (PST)
From: Petetin Max <petetin.max at gmail.com>
Reply-To: mcx-users at googlegroups.com
To: mcx-users

Dear Professor Fang,

I have a question concerning the feature unitinmm and more especially about its association with the function mcxdettime in Mcxlab.

Shouldn't be detp.ppath multiplied by unitinmm in this function (picture 6&7) ?

In fact, when I try it in a source / detector example in transmission geometry, I have the same results as when I do not use unitinmm concerning the time resolution.

In this example attached, I used unitinmm to transform a 404040 (in mm) grid into a 888 by using a unitinmm factor of 0.2. It is possible to see this difference in the spatial representation (picture 2 &3) but impossible to see it in the time resolution after using mcxdettime (picture 4& blue plot in picture 5).

Therefore, when I implement the unitinmm in a copy of mcxdettime I obtain the coherent result (red plot in picture 5) that I should obtain regarding the theorical result (picture 1).

Thank you in advance for your answer.

Best,
Max

Picture 1_theoretical results
Picture 2 _ case 8mm _ spatial representation
Picture 3 _ case 8mm with unitinmm _ spatial representation
Picture 4 _ case 8mm _ time resolution
Picture 5_ case 8mm with unitinmm_ time resolution
Picture 6_mcxdettime_code
Picture 7_mcxdettime_unitinmm_code

@fangq fangq closed this as completed in 1c07b16 Nov 19, 2019
fangq added a commit that referenced this issue Nov 19, 2019
jdtatz pushed a commit to jdtatz/mcx that referenced this issue Jul 15, 2020
jdtatz pushed a commit to jdtatz/mcx that referenced this issue Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant