[match] Fixes Gitlab Secure Files API limit (#21361)

Co-authored-by: Darby Frey <dfrey@gitlab.com>
fastlane · Jul 4, 2023 · 37f2f6c · 37f2f6c
1 parent ba801c7
commit 37f2f6c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/match/lib/match/storage/gitlab/client.rb b/match/lib/match/storage/gitlab/client.rb
@@ -40,6 +40,8 @@ def authentication_value
         def files
           @files ||= begin
             url = URI.parse(base_url)
+            # 100 is maximum number of Secure files available on Gitlab https://docs.gitlab.com/ee/api/secure_files.html
+            url.query = [url.query, "per_page=100"].compact.join('&')
 
             request = Net::HTTP::Get.new(url.request_uri)
 

diff --git a/match/spec/storage/gitlab/client_spec.rb b/match/spec/storage/gitlab/client_spec.rb
@@ -118,6 +118,15 @@
         expect(subject.files.count).to be(0)
       end
 
+      it 'requests 100 files from the API' do
+        stub_request(:get, /gitlab.example.com/).
+          to_return(status: 200, body: [].to_json)
+
+        files = subject.files
+
+        assert_requested(:get, /gitlab.example.com/, query: "per_page=100")
+      end
+
       it 'raises an exception for a non-json response' do
         stub_request(:get, /gitlab.example.com/).
           with(headers: { 'PRIVATE-TOKEN' => 'abc123' }).