Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solve failed Google API calls #21518

Merged
merged 2 commits into from
Sep 17, 2023

Commits on Sep 16, 2023

  1. [supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solv…

    …e failed Google API calls
    joshdholtz committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    cbd63fb View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Rewrite expectation to ensure SUT is interrupted by raised error

    Otherwise if we just `expect(UI).to receive(:user_error!).with(…)` that will mock the `UI.user_error` call in the method being tested... and thus not make it `raise` anymore, which the rest of the implementation of that method will continue executing when run in the context of mocked tests while it would not in the real world, which means we would be testing a different behavior of the method
    AliSoftware committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    690f254 View commit details
    Browse the repository at this point in the history