-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iap additions #22049
Open
TCROC
wants to merge
48
commits into
fastlane:master
Choose a base branch
from
TCROC:tcroc/iap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
iap additions #22049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e subscription group
…, load subscription localization by id, and delete a subscription localization
…cription price points
…scriptions and subscription groups
… to existing loaded prices
merge fastlane/fastlane/master into tcroc/fastlane/master
- update_in_app_purchase - update_in_app_purchase_localization - create_in_app_purchase_localization - get_in_app_purchases fields param
syncing with fastlane master
5 tasks
I was trying it out using
However when running this: Spaceship::ConnectAPI.get_in_app_purchases(:app_id => "my_id") it yielded:
am I doing something wrong? This is my Gemfile: source "https://rubygems.org"
gem "pry"
gem "fastlane", :git => "https://github.com/TCROC/fastlane", :branch => "tcroc/iap" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #20996. @vanniktech expressed a desire to get these changes into master. The original author of the previous PR isn't responding. Tbh, I haven't used these since last summer BUT I do plan on using them in our new title very soon (probably in ~2 months). Here's is a PR with "Allows edits by maintainers" set to true so the maintainers can get this in faster if they so desire.
If you want to wait for me to resolve the merge conflicts, it probably won't be for at least another 2 months. But please feel free to make any changes yourself. I hope this helps you out @vanniktech :)