Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass data to templates #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass data to templates #274

wants to merge 1 commit into from

Conversation

WiseBird
Copy link

Added a way to pass arbitrary data to templates.
Removed bypassSecurityTrustHtml for user-provided templates, its totally unsafe to use it.
Fixed class for html inserted via innerHTML (from sn-content to sn-html).

Removed bypassSecurityTrustHtml for user-provided templates, its totally unsafe to use it.
Fixed class for html inserted via innerHTML (from sn-content to sn-html)
@WiseBird
Copy link
Author

WiseBird commented Nov 14, 2017

@flauc Hello, build failed but I believe the cause is not in the PR, please take a look.

@WiseBird
Copy link
Author

@flauc Could you please review this PR it's really holding me back.

@flauc
Copy link
Owner

flauc commented Jan 24, 2018

Hi @WiseBird, I'm sorry this is taking so long I'm very short on time recently. Will do my best to have it merged tonight.

@worthy7
Copy link

worthy7 commented Mar 30, 2018

#deadproject

@Abenezer Abenezer mentioned this pull request Apr 14, 2018
@prcbass
Copy link

prcbass commented Apr 15, 2018

Feel free to look into the issue @worthy7. Project is clearly not dead since owner just released v1.0.0 to fix a bug. He's doing this for free.

@worthy7
Copy link

worthy7 commented Apr 16, 2018

True, I am thankful!

@cubidobusinesssolutions

I am also looking forward to see this PR merged :) @WiseBird Please merge/rebase and push in order to have the failed checks gone..

@WiseBird
Copy link
Author

@cubidobusinesssolutions I switched to https://github.com/scttcper/ngx-toastr

@wlievens
Copy link

Any news on this feature? I need this pretty badly...

@intellix
Copy link

This library looks nice and appreciate the effort that went into it but now we're after TemplateContexts we've got to transition to ngx-toastr.

Maybe it would be better for us all to focus our efforts on ngx-toastr (which even has ng7 support already) and add a deprecation notice on this project that points there?

@wsh92
Copy link

wsh92 commented Nov 12, 2018

@flauc Any update on this feature/Pull request? I need this pretty badly...

@wsh92
Copy link

wsh92 commented Nov 12, 2018

@cubidobusinesssolutions I switched to https://github.com/scttcper/ngx-toastr

@WiseBird do ngx-toastr have template context feature?

@WiseBird
Copy link
Author

@wsh92 Yes, but it uses different approach: you create custom component for notification and pass there any data you like.

@wsh92
Copy link

wsh92 commented Nov 14, 2018

@WiseBird Thanks, it is working like charm:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants