-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: missing make manifests
and make docs-update
before commit
#590
Comments
The following two files should be consistent with the code, the other docs like charts and manifests are all generated based on the following two files. The cards in https://github.com/fluent/fluent-operator/blob/master/Makefile#L54 |
@benjaminhuo I didn't make the changes manually, I launched |
Fixes #590 Update CRDs description / Documentation, conform to code
Describe the issue
I found some discrepancies between code and CRDs description/Documentation:
code [apis/fluentd/v1alpha1/plugins/common/buffer_types.go]:
Whereas in CRDs
crds [charts/fluent-operator/crds/fluentd.fluent.io_clusteroutputs.yaml]:
To Reproduce
launch the commands:
make manifests
make docs-update
Expected behavior
No modification after launching these commands
Your Environment
How did you install fluent operator?
#N/A
Additional context
#N/A
The text was updated successfully, but these errors were encountered: