Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support datadog plugin api key to allow for secret injection #1070

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

nitintecg
Copy link
Contributor

What this PR does / why we need it:

Modified datadog_types.go file to support datadog plugin api key for allowing the value to take from secret.

Which issue(s) this PR fixes:

Fixes #1060

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@benjaminhuo
Copy link
Member

@nitintecg Thanks for this PR.
You'll need to run the following to generate code and docs:

make manifests
make generate
make fmt
make vet
make docs-update

@nitintecg
Copy link
Contributor Author

@benjaminhuo I'm getting below error while running make generate and make manifests commands

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference

@benjaminhuo
Copy link
Member

@benjaminhuo I'm getting below error while running make generate and make manifests commands

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference

@wenchajun @wanjunlei This is an env issue?

@wenchajun
Copy link
Member

You can check the go and controller_gem version,https://github.com/fluent/fluent-operator/blob/master/Makefile#L149

@nitintecg
Copy link
Contributor Author

nitintecg commented Mar 10, 2024

@wenchajun Thanks, it was go version issue and after installing proper go version it resolved my issue.
@benjaminhuo after running commands its generating docs for multine_types.go and rewritetag_types.go.
So its expected in this PR or should i exclude docs changes for multiline_types.go and rewritetag_types.go from my PR ?

@benjaminhuo
Copy link
Member

benjaminhuo commented Mar 11, 2024

@benjaminhuo after running commands its generating docs for multine_types.go and rewritetag_types.go.
So its expected in this PR or should i exclude docs changes for multiline_types.go and rewritetag_types.go from my PR ?

@nitintecg yeah, it's ok. Someone else forgets to generate docs for their PRs.
would you push your new changes?

@nitintecg
Copy link
Contributor Author

@benjaminhuo i have added docs changes in this PR. Can you review ?

@fernandoataoldotcom
Copy link

@benjaminhuo i have added docs changes in this PR. Can you review ?

@nitintecg thanks a lot for working on this! We're adopting fluent bit and definitely need this capability.

@benjaminhuo
Copy link
Member

@nitintecg would you help to resolve the conflicts?

@nitintecg
Copy link
Contributor Author

@benjaminhuo , i tried resolving conflicts and was running commands for generating docs but while running make docs-update its giving below error.

Error while generating documentation: open ./docs/plugins/fluentbit/multilineparser/multilineparser.md: no such file or directory

Can you help me ?

@venkatamutyala
Copy link

@nitintecg The error you had might have been fixed around the time you had it. Please see: #1120

Signed-off-by: nitintecg <nitin.tejuja12@gmail.com>
@benjaminhuo benjaminhuo merged commit 478b5fd into fluent:master Apr 23, 2024
9 of 10 checks passed
@benjaminhuo
Copy link
Member

@nitintecg Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog fluentbit ouput plugin Api Key secret
5 participants