Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release cycles for fluentd and fluentbit images manually. #1183

Merged
merged 2 commits into from
May 28, 2024

Conversation

sarathchandra24
Copy link
Collaborator

What this PR does / why we need it:

#1178
#1079

  1. Current Github workflows are following the same release cycle.
  2. We have three different images fluent-bit, fluent-operator and fluentd, but these are on different release cycle and following same tag doesn't apply. Also we don't want to fallback on the make files again.
  3. So instead of creating the images using tags, it asks for a input of what release number to follow and then docker image tags are build likewise.

Links to workflow runs:

  1. Fluent Operator released on tag: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248567473
  2. Fluent Operator released on master: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248514441
  3. Fluent Bit released manually by specifying tag as input for workflow: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248457484
  4. Fluentd released manually by specifying tag as input for workflow: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248735165

How to trigger manually

image

Which issue(s) this PR fixes:

Fixes #1178

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


sarathchandra24 and others added 2 commits May 26, 2024 23:30
* manual Fluent bit image tag

* manual Fluent bit image tag

Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
@benjaminhuo
Copy link
Member

benjaminhuo commented May 28, 2024

That's terrific, thank you! @sarathchandra24

@benjaminhuo benjaminhuo merged commit df135ee into fluent:master May 28, 2024
9 of 10 checks passed
@sarathchandra24 sarathchandra24 self-assigned this May 28, 2024
@sarathchandra24
Copy link
Collaborator Author

Fluentd image build successful for tag 1.15.3: https://github.com/fluent/fluent-operator/actions/runs/9262668827
Fluent Bit image build successful for tag 3.0.4: https://github.com/fluent/fluent-operator/actions/runs/9262666460

@benjaminhuo
Copy link
Member

benjaminhuo commented May 28, 2024

image
image

v3.0.4
3.0.4
v3.0
3.0

I can see some extra tag is built v3.0.4 and 3.0.4, v3.0 and 3.0, the helm chart are actually using v3.0.4 only.
Is this expected?

@sarathchandra24

@sarathchandra24
Copy link
Collaborator Author

Yes as per semver thing it is expected, but I can remove it if required. So when ever we release a x.y.z it will also tag x.y to x.y.z. it is controlled over here https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fb-image.yaml#L126-L129 and https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fb-image.yaml#L65-L68. I think it's ok to have it, but if you want me to remove it I can raise a PR for it.

@benjaminhuo
Copy link
Member

I think it's ok to have it, but if you want me to remove it I can raise a PR for it.

it's ok to keep it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: tags missing from images in docker hub
2 participants