feat(output): fluent-bit integrate OpenSearch plugin #298
Conversation
| // Prefix keys with this string | ||
| LogstashPrefixKey string `json:"logstashPrefixKey,omitempty"` | ||
| // When enabled, mapping types is removed and Type option is ignored. Types are deprecated in APIs in v7.0. This options is for v7.0 or later. | ||
| SuppressTypeName string `json:"suppressTypeName,omitempty"` |
There was a problem hiding this comment.
https://docs.fluentbit.io/manual/pipeline/outputs/opensearch
When enabled, mapping types is removed and Type option is ignored.
The value defaults to off.This appears to have only on and off values, which seems to be possible with bool types?
There was a problem hiding this comment.
Thanks, I would to fix now.
|
The corresponding crd file does not seem to be generated here |
| openSearchOutput := ClusterOutput{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| APIVersion: "fluentbit.fluent.io/v1alpha2", | ||
| Kind: "Output", |
There was a problem hiding this comment.
Yes, there should be ClusterOutput. I noticed that there are many place used Output, Input or Filter in fluent-bit config, seems they should be also need add a Cluster prefix, and do we need solve also in this PR?
There was a problem hiding this comment.
The kind should always be clusterxxx for fluentbit crds like this https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/clusterinput_types.go#L52
But we needn't change the internal structure to clusterxxx like this: https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/clusterinput_types.go#L34
There was a problem hiding this comment.
input, output, filter parser CRDs are all changed to clusterxxx in v1.0.0
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "opensearch_output_0", | ||
| Namespace: "testnamespace", |
There was a problem hiding this comment.
No namespace I think if use cluster CRD.
There was a problem hiding this comment.
Got, I will fix. thanks.
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
|
Thank you for your contribution @mangoGoForward ! |
Signed-off-by: mango xu.weiKyrie@foxmail.com
What this PR does / why we need it:
Fluent-bit integrate OpenSearch plugin
Which issue(s) this PR fixes:
Fixes #284
Does this PR introduced a user-facing change?