-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): support fluentd loki output #346
feat(plugin): support fluentd loki output #346
Conversation
@fatpa Thanks for the contribution! git commit -s --amend
git push -f Thanks! |
998a70a
to
458c810
Compare
Signed-off-by: Fatpa <fatpa.cai@gmail.com>
Signed-off-by: Fatpa <fatpa.cai@gmail.com>
Signed-off-by: Fatpa <fatpa.cai@gmail.com>
Signed-off-by: Fatpa <fatpa.cai@gmail.com>
458c810
to
3f2c4e5
Compare
Of course. Done. |
As far as I know, the fluentd image doesn't have the loki plugin built in, so we should modify this dockerfile file. |
Why add a new TLS plugin in in addition, we should move the |
Just follow the current design for the apis/fluentd and avoid the differences between fluentd and fluentbit. |
I will add it. |
Signed-off-by: Fatpa <fatpa.cai@gmail.com>
f5a5ad4
to
acd27bf
Compare
@wenchajun You can create another PR to move tls to a common place |
@fatpa Thanks very much for the contribution! |
@fatpa Would you please create another PR to add docs to the Fluentd Loki plugin as https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentd/index.md ? Thanks |
Sure. I will make it in a few days. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #310
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: