Adding Splunk output-types for fluentbit #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
momoXD007
force-pushed
the
splunk_support
branch
from
ff63d94
to
91ae38d
Compare
wenchajun
reviewed
Oct 7, 2022
| // +kubebuilder:validation:Maximum:=65535 | ||
| Port *int32 `json:"port,omitempty"` | ||
| // Specify the Authentication Token for the HTTP Event Collector interface. | ||
| SplunkToken string `json:"splunk_token,omitempty"` |
wenchajun
reviewed
Oct 7, 2022
| HTTPPasswd *plugins.Secret `json:"httpPassword,omitempty"` | ||
| // If the HTTP server response code is 400 (bad request) and this flag is enabled, it will print the full HTTP request | ||
| // and response to the stdout interface. This feature is available for debugging purposes. | ||
| HTTPDebugBadRequest bool `json:"httpDebugBadRequest,omitempty"` |
There was a problem hiding this comment.
| HTTPDebugBadRequest bool `json:"httpDebugBadRequest,omitempty"` | ||
| // When enabled, the record keys and values are set in the top level of the map instead of under the event key. Refer to | ||
| // the Sending Raw Events section from the docs for more details to make this option work properly. | ||
| SplunkSendRaw bool `json:"splunkSendRaw,omitempty"` |
wenchajun
requested changes
Oct 7, 2022
| kvs.Insert("HTTP_Passwd", pwd) | ||
| } | ||
| if o.Compress != "" { | ||
| kvs.Insert("Index", o.Compress) |
| kvs.Insert("Index", o.Compress) | ||
| } | ||
| if o.Channel != "" { | ||
| kvs.Insert("Type", o.Channel) |
|
@wanjunlei would you help to review this? |
|
These two commands should be executed after the changes are made. |
wanjunlei
requested changes
Oct 9, 2022
| if o.SplunkToken != "" { | ||
| kvs.Insert("Splunk_Token", o.SplunkToken) | ||
| } | ||
| if o.BufferSize != "" { |
There was a problem hiding this comment.
should be http_buffer_size
| func (o *Splunk) Params(sl plugins.SecretLoader) (*params.KVs, error) { | ||
| kvs := params.NewKVs() | ||
| if o.Host != "" { | ||
| kvs.Insert("Host", o.Host) |
There was a problem hiding this comment.
Uppercase is not recommended for code consistency.
kvs.Insert("Host", o.Host) => kvs.Insert("host", o.Host)
Others also need to be modified.
| if o.HTTPDebugBadRequest { | ||
| kvs.Insert("HTTP_Debug_Bad_Request", "On") | ||
| } else { | ||
| kvs.Insert("HTTP_Debug_Bad_Request", "Off") |
There was a problem hiding this comment.
It is redundant, the default is Off.
| if o.SplunkSendRaw { | ||
| kvs.Insert("Splunk_Send_Raw", "On") | ||
| } else { | ||
| kvs.Insert("Splunk_Send_Raw", "Off") |
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
momoXD007
force-pushed
the
splunk_support
branch
from
f4e91e3
to
0284128
Compare
|
I hopefully fixed all findings n ow :) Thanks for looking into this so quickly |
wanjunlei
reviewed
Oct 10, 2022
| kvs.Insert("splunk_token", o.SplunkToken) | ||
| } | ||
| if o.BufferSize != "" { | ||
| kvs.Insert("buffer_size", o.BufferSize) |
There was a problem hiding this comment.
buffer_size => http_buffer_size
wenchajun
reviewed
Oct 10, 2022
| SplunkToken string `json:"splunkToken,omitempty"` | ||
| //Buffer size used to receive Splunk HTTP responses: Default `2M` | ||
| // +kubebuilder:validation:Pattern:="^\\d+(k|K|KB|kb|m|M|MB|mb|g|G|GB|gb)?$" | ||
| BufferSize string `json:"bufferSize,omitempty"` |
There was a problem hiding this comment.
bufferSize -> httpBufferSize
There was a problem hiding this comment.
ah, ok that's what you meant, will fix that :)
| Compress string `json:"compress,omitempty"` | ||
| // Specify X-Splunk-Request-Channel Header for the HTTP Event Collector interface. | ||
| Channel string `json:"channel,omitempty"` | ||
|
|
There was a problem hiding this comment.
There is no need for a blank line here.
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
wenchajun
approved these changes
Oct 10, 2022
wanjunlei
approved these changes
Oct 10, 2022
benjaminhuo
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to fluent-operator to configure Splunk as an output for fluentbit. Fluentbit already supports Splunk as output but so far fluent-operator simply can not configure a fluentbit-pod to actually make use of that. This PR intends to change that.
In other words it enables users of the fluent-operator to use more of the features fluentbit already has.
I am not an experienced go-developer and have simply used similar PRs (e.g.: PRs that add the opensearch-output types) and fluentbits' documentation for Splunk (here) as base for my work.
Please review and test carefully.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: