Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Time_Offset parameter in regex parser #423

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Added support for Time_Offset parameter in regex parser #423

merged 2 commits into from
Oct 17, 2022

Conversation

nemcikjan
Copy link
Contributor

What this PR does / why we need it:

Adds support to define Time_Offset parameter on regex parser

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

@nemcikjan nemcikjan changed the title Patch 1 Added support for Time_Offset parameter in regex parser Oct 12, 2022
@wenchajun
Copy link
Member

Seems that DCO failed, please commit with a signature.

git config --global user.name <name>
git config --global user.email <email>
git commit -s -m "xxx"

@benjaminhuo
Copy link
Member 

git commit -s --amend
git push -f

@nemcikjan nemcikjan force-pushed the patch-1 branch 2 times, most recently from b3f2131 to 52e382e Compare October 17, 2022 05:54
nemcikjan and others added 2 commits October 17, 2022 07:57
@nemcikjan
Added Time_Offset parameter for regex parser
72db675 
Signed-off-by: Jan Nemcik <janynemcik5@gmail.com>
@nemcikjan
updated docs and manifests for cluster parser
432765d 
Signed-off-by: Jan Nemcik <janynemcik5@gmail.com>
@nemcikjan
Copy link
Contributor Author

@wenchajun @benjaminhuo thanks for help

@benjaminhuo benjaminhuo merged commit b4efc09 into fluent:master Oct 17, 2022
@benjaminhuo
Copy link
Member

@JanNemcik Thank you for the contribution!

@nemcikjan nemcikjan deleted the patch-1 branch October 17, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo left review comments

@wenchajun wenchajun wenchajun approved these changes

@wanjunlei wanjunlei Awaiting requested review from wanjunlei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nemcikjan @wenchajun @benjaminhuo