changing type of SplunkToken from string to secret #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In my last PR I added support for Splunk as output type. I however missed the fact that the so called SplunkToken is an authentication-token and should therefore be treated as a secret.
Context:
A SplunkToken is a Splunk generated string that can be used by programs to access a Splunk-instance's api. It is therefore a sensitive secret and should be handled as such.
Which issue(s) this PR fixes:
I think no one raised this externally, but the underlying issue that this fixes is that this change will force users to supply the SplunkToken as secret reference and this way prevents leaking of this secret.
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: