Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more fluent-bit configurations configurable via the FluentBit resource #452

Merged

Conversation

Kristian-ZH
Copy link
Member

@Kristian-ZH Kristian-ZH commented Nov 21, 2022

What this PR does / why we need it:

Adds more configurations in the fluent-bit Daemonset. In this way, FB becomes more extensible and flexible for different scenarios.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

New configurations are added in the FluentBit Spec: command, livenessProbe, readinessProbe, initContainers, ports.

@Kristian-ZH Kristian-ZH changed the title Extract additional fluent-bit configurations Make more fluent-bit configs configurable via the FluentBit resource Nov 21, 2022
@Kristian-ZH Kristian-ZH changed the title Make more fluent-bit configs configurable via the FluentBit resource Make more fluent-bit configurations configurable via the FluentBit resource Nov 21, 2022
@Kristian-ZH Kristian-ZH force-pushed the extract-additional-fluent-bit-configs branch from d45503f to 476038d Compare November 21, 2022 12:01
@benjaminhuo
Copy link
Member

Thanks, @Kristian-ZH for the contribution! @wanjunlei @wenchajun would you help to review?
You'll need to sign your commit like this:

git commit -s --amend
git push -f

Signed-off-by: Kristian Zhelyazkov <k.zhelyazkov@sap.com>
Signed-off-by: Kristian-ZH <k.zhelyazkov@sap.com>
@Kristian-ZH Kristian-ZH force-pushed the extract-additional-fluent-bit-configs branch from 476038d to b72d491 Compare November 21, 2022 12:03
@benjaminhuo benjaminhuo merged commit cfaadaf into fluent:master Nov 23, 2022
@Kristian-ZH Kristian-ZH deleted the extract-additional-fluent-bit-configs branch November 23, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants