Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fluentbit template render error - fixes #457 #458

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

rothwerx
Copy link
Contributor

Signed-off-by: Jeremiah Roth jeremiah@sundeck.io

What this PR does / why we need it:

Fixes template render error in fluentbit-fluentBit.yaml when adding more than one annotation, secret, volume, volumeMount.

Which issue(s) this PR fixes:

Fixes #457

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: Jeremiah Roth <jeremiah@sundeck.io>
@benjaminhuo
Copy link
Member

@rothwerx Thanks for the contribution!

@benjaminhuo benjaminhuo merged commit 5acd03d into fluent:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: YAML parse error when rendering templates/fluentbit-fluentBit.yaml
3 participants