Add fluent-bit service and option to extend the RBAC configurations #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristian-ZH <k.zhelyazkov@sap.com>
benjaminhuo
approved these changes
Nov 23, 2022
|
@Kristian-ZH This is a significant enhancement, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristian-ZH k.zhelyazkov@sap.com
What this PR does / why we need it:
The PR adds fluent-bit service that can be disabled with the configuration
DisableService. It also adds an option to extend the RBAC configurations through the FB/Fluentd Spec config file.Motivation:
The Service is needed in case you want to easily scrape metrics from the fluent-bit from Prometheus for example.
The RBAC extension is needed in case you deploy your custom output plugin (As the operator and the FB itself already support this option) and this custom plugin works with additional resources.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?