feat: adding support for labels for fluent-operator and fluent-bit pods #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
benjaminhuo
reviewed
Nov 24, 2022
benjaminhuo
reviewed
Nov 24, 2022
benjaminhuo
previously approved these changes
Nov 24, 2022
|
@momoXD007 Thanks for the explanation, I understand your point now. |
Signed-off-by: Michael Wieneke <momoXD007@users.noreply.github.com>
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
|
@benjaminhuo I fixed the merge-conflict and adde and if-condition around the annotations. This way annotations are ignored if none are provided :) |
benjaminhuo
approved these changes
Nov 24, 2022
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the functionality to add labels to to fluent-bit and fluent-operator.
I tested it with
helm templatea few times and it looks good. So at least no obvious helm errors However, I did not deploy it anywhere so far. Please test carefully before merging.Which issue(s) this PR fixes:
partially addresses: #456
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: