fix: added Collector CRD to kustomization & Helm ClusterRole template #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchajun
previously approved these changes
Jan 24, 2023
|
@wenchajun you'll need to merge the changes in fluent/helm-charts#299 to this repo, and then this PR needs to be rebased on the latest helm charts changes |
|
@jjsiv Would you help to rebase your PR and resolve the conflicts? |
… template Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
|
Looks like the test went through ok but it failed on cleanup for some reason... |
benjaminhuo
approved these changes
Feb 1, 2023
I've made some changes to the CI script and now the CI work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
I guess this was missed as a part of #484 - currently 'make manifests' does not generate the Collector CRD in manifests/setup because kustomization is missing it.
Also Fixes #513 - added Collector to the ClusterRole Helm template
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: