Refining the fluent-operator chart #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchajun
force-pushed
the
new-helm
branch
2 times, most recently
from
f56503c
to
e8150f2
Compare
benjaminhuo
reviewed
Jan 28, 2023
README.md
Outdated
|
|
||
| You can also deploy the Kubernetes logging stack with Helm, just need to set the `Kubernetes` parameter to `ture`: | ||
| You can also deploy the Kubernetes logging pipeline with Helm, just need to set the `Kubernetes` parameter to `true`: |
There was a problem hiding this comment.
Suggested change
| You can also deploy the Kubernetes logging pipeline with Helm, just need to set the `Kubernetes` parameter to `true`: | |
| You can also deploy the Kubernetes logging pipeline with Helm, just need to set the `Kubernetes` parameter to `true` (default): |
benjaminhuo
reviewed
Jan 28, 2023
charts/fluent-operator/values.yaml
Outdated
| requests: | ||
| cpu: 100m | ||
| memory: 20Mi | ||
| resources: {} |
benjaminhuo
reviewed
Jan 28, 2023
| #Configure the output plugin parameter in Fluentd. | ||
| #You can set enable to true to output logs to the specified location. | ||
| resources: | ||
| limits: |
There was a problem hiding this comment.
fluentd limits is too small
There was a problem hiding this comment.
200m and 200Mi is still too small
benjaminhuo
reviewed
Jan 28, 2023
charts/fluent-operator/values.yaml
Outdated
| @@ -92,7 +100,7 @@ fluentbit: | |||
| tail: | |||
| memBufLimit: 5MB | |||
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics | |||
| # nodeExporterMetrics: | |||
| nodeExporterMetrics: | |||
There was a problem hiding this comment.
Why enable nodeExporterMetrics by default?
wenchajun
force-pushed
the
new-helm
branch
5 times, most recently
from
6838e5a
to
9831e97
Compare
benjaminhuo
reviewed
Jan 28, 2023
charts/fluent-operator/values.yaml
Outdated
| @@ -92,7 +100,7 @@ fluentbit: | |||
| tail: | |||
| memBufLimit: 5MB | |||
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics | |||
There was a problem hiding this comment.
Suggested change
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics | |
| nodeExporterMetrics: {} | |
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics |
benjaminhuo
reviewed
Jan 28, 2023
benjaminhuo
reviewed
Jan 28, 2023
charts/fluent-operator/values.yaml
Outdated
| @@ -92,7 +100,7 @@ fluentbit: | |||
| tail: | |||
| memBufLimit: 5MB | |||
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics | |||
There was a problem hiding this comment.
Suggested change
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics | |
| # uncomment below nodeExporterMetrics section if you want to collect node exporter metrics |
wenchajun
force-pushed
the
new-helm
branch
3 times, most recently
from
690dda4
to
db0f476
Compare
Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
benjaminhuo
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chengdehao dehaocheng@kubesphere.io
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: