Fix the bug of adding label #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
benjaminhuo
reviewed
Feb 6, 2023
| if fb.Spec.Labels != nil { | ||
| labels = fb.Spec.Labels | ||
| } else { | ||
| labels = fb.Labels |
There was a problem hiding this comment.
Why using fb.Labels if fb.spec.Labels is nil?
fb.spec.Labels should be the only place to set labels for the fluentbit daemonset and its pod as defined in
https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/fluentbit_types.go#L71
There was a problem hiding this comment.
If the label is not set in advance, an empty error is displayed. This error message is prompted empty selector is invalid for daemonset. This way, if the user does not configure the label parameters, the default parameters are used, and if they are used, the user-configured ones fb.spec.Labels are used.
benjaminhuo
approved these changes
Feb 7, 2023
benjaminhuo
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chengdehao dehaocheng@kubesphere.io
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: