fluent operator & fluentbit: Added tolerations, nodeSelector + more #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flxman <felix.farjsjo@gmail.com>
felfa01
changed the title
Signed-off-by: illrill <richard.jimmy.johansson@gmail.com>
felfa01
changed the title
felfa01
changed the title
wenchajun
reviewed
Apr 26, 2023
Comment on lines
102
to
104
| imagePullSecrets: {{ toYaml .Values.operator.imagePullSecrets | nindent 8 }} | ||
| {{- end }} | ||
| {{- if .Values.operator.tolerations }} |
There was a problem hiding this comment.
maybe
imagePullSecrets:
{{ toYaml .Values.operator.imagePullSecrets | nindent 8 }}
{{- end }}
better
There was a problem hiding this comment.
Indentation style is now aligned with the rest of the manifest.
| imagePullSecrets: {{ toYaml .Values.operator.imagePullSecrets | nindent 8 }} | ||
| {{- end }} | ||
| {{- if .Values.operator.tolerations }} | ||
| tolerations: {{ toYaml .Values.operator.tolerations | nindent 8 }} |
| tolerations: {{ toYaml .Values.operator.tolerations | nindent 8 }} | ||
| {{- end }} | ||
| {{- if .Values.operator.nodeSelector }} | ||
| nodeSelector: {{ toYaml .Values.operator.nodeSelector | nindent 8 }} |
| nodeSelector: {{ toYaml .Values.operator.nodeSelector | nindent 8 }} | ||
| {{- end }} | ||
| {{- if .Values.operator.podSecurityContext }} | ||
| podSecurityContext: {{ toYaml .Values.operator.podSecurityContext | nindent 8 }} |
Signed-off-by: illrill <richard.jimmy.johansson@gmail.com>
wenchajun
approved these changes
Apr 26, 2023
benjaminhuo
approved these changes
Apr 26, 2023
|
@felfa01 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added support for tolerations, nodeSelector, priorityClassName and podSecurityContext to fluent-operator deployment and fluentbit daemonset
Which issue(s) this PR fixes:
Fixes fluent/helm-charts#314
Fixes #695
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: