Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[summerospp]add fluentbit opentelemetry plugin #890

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

sjliu1
Copy link
Contributor

@sjliu1 sjliu1 commented Aug 26, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: 刘帅军 <liudonglan@liudonglandeMacBook-Pro.local>
wenchajun
wenchajun previously approved these changes Aug 26, 2023
Copy link
Collaborator

@jjsiv jjsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you check the failing test?

wenchajun
wenchajun previously approved these changes Aug 28, 2023
wenchajun
wenchajun previously approved these changes Aug 30, 2023
@@ -156,6 +156,42 @@ spec:
plugin.
type: string
type: object
opentelemetry:
Copy link
Member

@benjaminhuo benjaminhuo Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjliu1 Still opentelemetry , You'll need to regenerate the yaml by make test
And the opentelemetry in the helm chart needs to be changed to openTelemetry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have done it.

Signed-off-by: 刘帅军 <liudonglan@192.168.2.101>
benjaminhuo
benjaminhuo previously approved these changes Aug 30, 2023
@benjaminhuo
Copy link
Member

Can the docs here https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/index.md be generated by make docs-update ? @wenchajun

@wenchajun
Copy link
Member

Can the docs here https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/index.md be generated by make docs-update ? @wenchajun

Yes, it can be generated automatically.

@benjaminhuo
Copy link
Member

Can the docs here https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/index.md be generated by make docs-update ? @wenchajun

Yes, it can be generated automatically.

@sjliu1 You'll need to update the docs as well

Signed-off-by: 刘帅军 <liudonglan@192.168.2.101>
wenchajun and others added 2 commits August 30, 2023 14:50
Signed-off-by: Elon Cheng <dehaocheng@kubesphere.io>
Signed-off-by: SjLiu <139106424+sjliu1@users.noreply.github.com>
@sjliu1 sjliu1 closed this Aug 30, 2023
@sjliu1 sjliu1 reopened this Aug 30, 2023
@sjliu1
Copy link
Contributor Author

sjliu1 commented Aug 30, 2023

Can the docs here https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/index.md be generated by make docs-update ? @wenchajun

Yes, it can be generated automatically.

@sjliu1 You'll need to update the docs as well

OK, done

@benjaminhuo benjaminhuo merged commit 9f220bc into fluent:master Aug 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants