Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed waiting to complete the animation if user pressed the butto… #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zubairehman
Copy link

@zubairehman zubairehman commented Mar 7, 2024

removed waiting to complete the animation if user pressed the like button multiple times. Since we are already resetting controller in click listener, so there is not need to wait for the animation to complete :)

@zmtzawqlp
Copy link
Member

maybe it should has a property to control this behavior. it's a breaking change for the user if we remove awaiting directly. and the user should take care of the status in the server side

@zubairehman
Copy link
Author

maybe it should has a property to control this behavior. it's a breaking change for the user if we remove awaiting directly. and the user should take care of the status in the server side

make sense. I added a boolean filed which is true by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants