Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic DocField filter #1409

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jul 31, 2023

closes #1372
closes #1327

@ssiyad ssiyad added the enhancement New feature or request label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 3.57% and project coverage change: +0.01% 🎉

Comparison is base (5db0e3c) 13.15% compared to head (144c4dd) 13.16%.
Report is 12 commits behind head on main.

❗ Current head 144c4dd differs from pull request most recent head 6453da4. Consider uploading reports for the commit 6453da4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   13.15%   13.16%   +0.01%     
==========================================
  Files          56       56              
  Lines        1961     1967       +6     
==========================================
+ Hits          258      259       +1     
- Misses       1703     1708       +5     
Files Changed Coverage Δ
...hd_desk_account_request/hd_desk_account_request.py 0.00% <0.00%> (ø)
...lpdesk/helpdesk/doctype/hd_settings/hd_settings.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 21.75% <0.00%> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <0.00%> (ø)
helpdesk/utils.py 31.70% <16.66%> (-2.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad marked this pull request as ready for review August 1, 2023 09:20
@ssiyad ssiyad merged commit 3d95e26 into frappe:main Aug 1, 2023
4 of 5 checks passed
@ssiyad ssiyad deleted the feat/docfield_filter branch August 1, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate that filter is applied in list view Provision to add static Filters in list view
1 participant