Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import/export functionality #65

Merged
merged 18 commits into from
Apr 14, 2023
Merged

Add import/export functionality #65

merged 18 commits into from
Apr 14, 2023

Conversation

fregante
Copy link
Owner

@fregante fregante commented Apr 3, 2023

50% 15% written by copilot, wish us all luck

@fregante
Copy link
Owner Author

fregante commented Apr 4, 2023

Issues:

  • Defaults are exported too, but shouldn't (the module does not save them into storage at all)
  • Importing works, but the form is not updated, so you must manually reload the options page or else you override the import

@fregante
Copy link
Owner Author

fregante commented Apr 4, 2023

Defaults are exported too, but shouldn't (the module does not save them into storage at all)

If I do this, I have two options on import:

  • discard options that are stored but not present in the JSON
  • not reset missing options to the default value

Overall I think it would be a confusing output, so nah.

Importing works, but the form is not updated, so you must manually reload the options page or else you override the import

Tested in RGH, it works now

@fregante
Copy link
Owner Author

fregante commented Apr 14, 2023

Party-pooping safari as always. Bug known since 2020

https://bugs.webkit.org/show_bug.cgi?id=167341#c55

Screenshot

@fregante fregante merged commit e367be7 into main Apr 14, 2023
@fregante fregante deleted the import-export branch April 14, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add export feature
1 participant