Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendmsg support #52

Closed
goodboy opened this issue Dec 2, 2017 · 1 comment
Closed

Add sendmsg support #52

goodboy opened this issue Dec 2, 2017 · 1 comment
Assignees

Comments

@goodboy
Copy link
Member

goodboy commented Dec 2, 2017

Since moving to FreeSWITCH 1.6 I've had to disable a couple of the unit tests because of that I thought was a problem with certain events not being emitted by FS (in this case RECORD_STOP). After further investigation as part of #49 and #50 I am instead convinced that the problem is actually in using uuid_broadcast.

I believe this command is not working reliably (at least the same way it used to) and that parked sessions are not executing new dialplan apps requested using this method.

uuid_broadcast was only used initially due to switchy's dependence on the SWIG connection client (which we've since discarded) and not having an async way to invoke dialplan apps (i.e. there was no async way to support sendmsg). Now that we control the lower inbound protocol it makes to add this API support and stop using uuid_broadcast which is just a wrapper around what sendmsg would be doing anyway.

@moises-silva I'd appreciate your feedback on this as well!

@goodboy goodboy self-assigned this Dec 2, 2017
@goodboy
Copy link
Member Author

goodboy commented Dec 3, 2017

Heh I was totally right. Everything works perfectly with sendmsg...

goodboy pushed a commit that referenced this issue Dec 3, 2017
Deprecate `Session.broadcast()` as the FS core behaviour is unreliable.
Add `execute()` support and use throughout the session API for all
FS core app commands.

Resolves #52
@goodboy goodboy mentioned this issue Dec 3, 2017
@goodboy goodboy closed this as completed in 27490ae Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant