Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes D: set all values onInput #6517

Draft
wants to merge 3 commits into
base: v5/develop
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jun 29, 2024

Description

Summary of changes

  • Fields section submit all values on input of any field now (similar to on submit) instead of updating the one field

Reasoning

When we throttle the save call to the backend later on, we cannot just have the one updated value on the call that gets through, but always a full set of current/changed values.

Alternatively, panel.content would need to keep a temporary store of not-yet-saved changed values.

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jun 29, 2024
@distantnative distantnative self-assigned this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant