Merge Api classes
#6524
Draft
Merge Api classes
#6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
commented
Jul 4, 2024
| $this->assertTrue(in_array(setlocale(LC_TIME, 0), ['de', 'de_DE', 'de_DE.UTF-8', 'de_DE.UTF8', 'de_DE.ISO8859-1'])); | ||
| $this->assertTrue(in_array(setlocale(LC_MONETARY, 0), $de)); | ||
| $this->assertTrue(in_array(setlocale(LC_NUMERIC, 0), $de)); | ||
| $this->assertTrue(in_array(setlocale(LC_TIME, 0), $de)); | ||
| $this->assertSame($originalLocale, setlocale(LC_CTYPE, 0)); |
There was a problem hiding this comment.
@lukasbestle With priority Z/not urgent: This unit test now fails as we have added the setUp method setting an app object with a locale. At least that's why I think it fails. How would we need to alter this test method to pass but still ensure it checks the right things? Not fully understanding all the setLocale calls, so if you have an idea sometime, not urgent at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Cms\Apiclasses intoApinamespaceReasoning
We decided that we don't want to have the enforced separation CMS/other where it doesn't benefit us. I think for less complexity in the long run, it makes sense to merge these classes.
Additional context
Changelog
Fixes
Breaking changes
Docs
Ready?
For review team