Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hackathon indicator on presentation cards #7023

Merged
merged 6 commits into from
Jul 27, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Jun 30, 2020

Description

Fix townsqaure display

image

Fix hackathon townsquare

image

Fix profile cards

image

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #7023 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7023      +/-   ##
==========================================
+ Coverage   26.29%   26.31%   +0.02%     
==========================================
  Files         300      300              
  Lines       29392    29392              
  Branches     4322     4322              
==========================================
+ Hits         7728     7734       +6     
+ Misses      21393    21387       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46b424...b29d776. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoek1
Copy link
Contributor Author

zoek1 commented Jul 1, 2020

Yes sir! 👍

@octavioamu
Copy link
Contributor

@PixelantDesign @zoek1 what do you guys think about moving "looking for a project" to the next line, seems the size of the font and all the like don't fit visually.

@danlipert
Copy link
Contributor

@octavioamu I agree it does look quite funky

@thelostone-mc
Copy link
Member

@zoek could you resolve these conflicts and we can get this in

@Solexplorer
Copy link
Contributor

bump

@frankchen07
Copy link
Contributor

LGTM, with the caveat that because there's been alot of feedback about communications confusion, this might be a consideration we retire.

@danlipert danlipert merged commit f2f9b98 into gitcoinco:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Hackathon Gitcoin Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants