Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge: ens #7060

Merged
merged 5 commits into from
Jul 28, 2020
Merged

purge: ens #7060

merged 5 commits into from
Jul 28, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 5, 2020

Description

purge ens feature

Tested locally

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #7060 into master will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7060      +/-   ##
==========================================
- Coverage   26.27%   26.23%   -0.04%     
==========================================
  Files         301      295       -6     
  Lines       29455    29134     -321     
  Branches     4330     4305      -25     
==========================================
- Hits         7740     7644      -96     
+ Misses      21444    21219     -225     
  Partials      271      271              
Impacted Files Coverage Δ
app/app/settings.py 82.40% <ø> (-0.21%) ⬇️
app/app/urls.py 85.96% <ø> (-0.25%) ⬇️
...p/dashboard/management/commands/activity_report.py 0.00% <0.00%> (ø)
...p/grants/management/commands/sent_cart_reminder.py 0.00% <0.00%> (ø)
app/marketing/mails.py 11.00% <ø> (ø)
app/marketing/management/commands/pull_stats.py 0.00% <ø> (ø)
...management/commands/warn_when_wallet_out_of_eth.py 0.00% <0.00%> (ø)
app/marketing/stats.py 0.00% <ø> (ø)
app/marketing/views.py 11.90% <ø> (-0.13%) ⬇️
app/dashboard/utils.py 42.22% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0e770...b09f360. Read the comment docs.

@thelostone-mc thelostone-mc changed the title purge: ens purge: ens + css fixes for TS Jul 5, 2020
@thelostone-mc thelostone-mc changed the title purge: ens + css fixes for TS purge: ens Jul 5, 2020
@thelostone-mc thelostone-mc added this to Engineering-Review in PR Review Board Jul 5, 2020
Makefile Show resolved Hide resolved
app/faucet/templates/faucet_form.html Show resolved Hide resolved
app/grants/management/commands/sent_cart_reminder.py Outdated Show resolved Hide resolved
@thelostone-mc
Copy link
Member Author

feedback comment addressed !

scripts/crontab Outdated Show resolved Hide resolved
@danlipert danlipert merged commit c435440 into gitcoinco:master Jul 28, 2020
PR Review Board automation moved this from Engineering-Review to Done Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants