Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsubscribe daily email people if they haven't read in the last 30 days #7077

Merged
merged 10 commits into from
Jul 28, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 7, 2020

Description

unsubscribe daily email people if they haven't read in the last 30 days

Refers/Fixes

https://gitcoincore.slack.com/archives/CB1N0L6F7/p1594141095159400

Testing

tested locally

@thelostone-mc thelostone-mc changed the base branch from stable to master July 8, 2020 09:01
@thelostone-mc thelostone-mc changed the base branch from master to stable July 8, 2020 09:03
@danlipert danlipert added this to Engineering-Review in PR Review Board Jul 9, 2020
@thelostone-mc thelostone-mc changed the base branch from stable to master July 10, 2020 04:15
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owocki CI is failing ! We can get this in once that is resolved

@owocki
Copy link
Contributor Author

owocki commented Jul 15, 2020

just fixed the linter + pushed

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #7077 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7077      +/-   ##
==========================================
- Coverage   26.30%   26.27%   -0.03%     
==========================================
  Files         300      301       +1     
  Lines       29424    29455      +31     
  Branches     4327     4330       +3     
==========================================
  Hits         7740     7740              
- Misses      21413    21439      +26     
- Partials      271      276       +5     
Impacted Files Coverage Δ
...ng/management/commands/unsubscribe_daily_emails.py 0.00% <0.00%> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.56% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0745546...fe39d6a. Read the comment docs.

@owocki
Copy link
Contributor Author

owocki commented Jul 15, 2020

ok its passing now.

@danlipert danlipert merged commit 5e0e770 into master Jul 28, 2020
PR Review Board automation moved this from Engineering-Review to Done Jul 28, 2020
@thelostone-mc thelostone-mc deleted the kevin/marketing_email_unsubscribe branch October 6, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants