Changed and added (a lot of...) Android functionality #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonzalo, why don't you merge this? |
|
Im reviewing this right now and testing, I will keep you posted throughout the day. Thanks @akreienbring for your contribution. |
|
Any update on this @gonzaloaune ? Seems like a lot of good stuff here. Edit: Just noticed "His plugin has iOS support, but I think I broke the compatibility with my changes.", which may be the reason why the merging is taking a while? |
|
Yes, I'm actually updating the iOS side since this pull request broke that functionality. I expect to have it ready by later today. |
|
Any update regarding this? |
|
@gonzaloaune any update on your review? will be using your plugin if you get this merged :) |
|
I'm also looking forward to this getting merged. |
|
I moved to this plugin... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gonzalo, thanks for the ground work you made.
I was in need of a plugin that uses the new GCM implementation. E.g. subscribing to topics was not possible with the (deprecated) phongegap-push-plugin.
So I found yours and reworked the Android part. It now has much more functionality and mimics the behaviour of phongegap-push-plugin in most of its parts.
Unfortunatly I don't think that the iOS implementation is still working because I changed your callback philosophy to an event based approach.
I hope you will merge this request and adjust the iOS code to my proposals.
Greetings,
André