PHP 8.1 compatibility & deprecation warnings #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full explanation: https://stackoverflow.com/a/71133750 Warnings: PHP Deprecated: Return type of Shippo_Object::offsetUnset($k) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 109 PHP Deprecated: Return type of Shippo_Object::offsetSet($k, $v) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 99 Shippo_Object implements ArrayAccess: https://www.php.net/manual/en/class.arrayaccess.php
|
Kudos, SonarCloud Quality Gate passed!
|
|
@smkrz or @assislucas Any chance that this could get merged in and tag for a new release? |
|
I'd also love to see this merged. |
|
Not to be annoying, but wanted to hopefully put this back on the radar for @assislucas and @smkrz for review and merging. |
|
Hi all, I have surfaced this to the right team at Shippo |
|
Thank you @assislucas! I'm sure I speak for everyone when I say that's a real MVP move! Looking forward to seeing this merged, and cleaning up some error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full explanation: https://stackoverflow.com/a/71133750
Shippo_Object implements ArrayAccess: https://www.php.net/manual/en/class.arrayaccess.php
Warnings getting in PHP log:
PHP Deprecated: Return type of Shippo_Object::offsetUnset($k) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 109
PHP Deprecated: Return type of Shippo_Object::offsetSet($k, $v) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 99