Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize use assert*() method in tests #5

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

peter-gribanov
Copy link
Member

Optimize use assert*() method in tests.

Change assertEquals() to assertSame().

Change

$this->assertTrue(is_callable(...));

to

$this->assertIsCallable(...);

@peter-gribanov peter-gribanov self-assigned this Jan 17, 2020
@peter-gribanov peter-gribanov added this to the Release 2.0 milestone Jan 17, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 83.019% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 83.019% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 83.019% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 83.019% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-17.0%) to 83.019% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 20df735 on peter-gribanov:optimize_use_assert into beb38a0 on gpslab:2.0.

@peter-gribanov peter-gribanov merged commit 505df87 into gpslab:2.0 Jan 17, 2020
@peter-gribanov peter-gribanov deleted the optimize_use_assert branch January 17, 2020 15:53
@peter-gribanov peter-gribanov mentioned this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants