-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus.operator.probes] Add namespace label with the namespace of the probe object #1058
base: main
Are you sure you want to change the base?
[prometheus.operator.probes] Add namespace label with the namespace of the probe object #1058
Conversation
@thampiotr Thanks for running the tests, I adapted the code a little according to the results. Can you try again? |
@thampiotr Thanks for running the tests again, for the failing results on this one, I'm not sure what the issues are or how to solve them. |
@thampiotr Noticed that the probe config tests are not successful, so added the expectation of a label with name namespace and value default. |
@thampiotr I changed the labelset from an array of sets to one object. |
@thampiotr, Is there something else for the moment I can do? (not sure how the full PR flow works) |
@thampiotr Adapted the test to have one list instead of a list in a list |
@ToonTijtgat2 you should be able to run most of the tests locally with |
Tijtgat Toon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@thampiotr it seems that all tests passed now, what do we have to do now to complete this PR? I saw that by accident I did one of the commits with an unknown user. I don't know if this is a problem about the cla? Thanks for checking. FYI, I try to run the tests locally but for a reason I get the following all the time. |
PR Description
Add namespace label with the namespace of the probe object in the static config to align with prometheus setup.
Prometheus automatically adds the namespace label, and since this is standard practice and we rely on this label for some dashboards and rules, we'd like to align the prometheus setup and alloy setup.
Which issue(s) this PR fixes
Fixes #1049
Notes to the Reviewer
PR Checklist