Prefix default variables #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefixing variables will allow flexible overrides in group_vars, host_vars and not collide with playbook defined variables. Also alines to all other grafana roles.
madalinignisca
requested review from
ishanjainn,
v-zhuravlev and
gardar
as code owners
|
|
|
yup LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose to prefix Alloy default variables to allow users to have flexibility for playbooks that run against many groups and be able to change things at host level.
Current non-prefixed, collided also with some other common named variables that might be used.
This also aligns Alloy to all the other Grafana roles.