Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [release-2.9.x] docs: Label filter expression: Change unit suffix suffix to proper case whe… #13345

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: [release-2.9.x] docs: Label filter expression: Change unit suffix suffix to proper case whe… #13345

merged 1 commit into from
Jul 1, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 91a3486 from #13344

Label filter expression: Change unit suffix suffix to proper case when dealing with a Byte datatype

What this PR does / why we need it:
This updates documentation to match functionality described in the source code here.

The lexer does not support lowercase units "kb" or "gb".

Please note I have removed E/PB and E/PiB and will be creating a separate issue for them as they do not seem to be supported at the time.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@nickgrafana @grafana-delivery-bot
docs: Label filter expression: Change unit suffix suffix to proper ca…
0264a99 
…se whe… (#13344)

Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit 91a3486)
@grafanabot grafanabot requested a review from a team as a code owner June 27, 2024 19:27
@grafanabot grafanabot added backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jun 27, 2024
@JStickler JStickler merged commit de3c8b0 into release-2.9.x Jul 1, 2024
17 checks passed
@JStickler JStickler deleted the backport-13344-to-release-2.9.x branch July 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grafanabot @JStickler @nickgrafana