Update vulture container image to run as non-root #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharaujo
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
|
@zalegrala would you mind having a look? |
zalegrala
reviewed
Jun 18, 2024
cmd/tempo-vulture/Dockerfile
Outdated
| RUN addgroup -g 10001 -S tempo && \ | ||
| adduser -u 10001 -S tempo -G tempo | ||
|
|
||
| RUN mkdir -p /var/tempo && \ |
There was a problem hiding this comment.
Vulture doesn't write data locally, and so the mkdir and associated chown aren't required.
Follow-up to grafana#2265 which missed tempo-vulture Signed-off-by: Pedro Araujo <phcrva@gmail.com>
pharaujo
force-pushed
the
vultureNonRootImage
branch
from
74069ce
to
a8ec52e
Compare
zalegrala
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow-up to #2265 which missed tempo-vulture
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]