[CHANGE] tempo-query: switch from grpcPlugin to standalone #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Jul 3, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * [CHANGE] **BREAKING CHANGE** Remove `autocomplete_filtering_enabled` feature flag [#3729](https://github.com/grafana/tempo/pull/3729) (@mapno) | |||
| * [CHANGE] Bump opentelemetry-collector to 0.102.1 [#3784](https://github.com/grafana/tempo/pull/3784) (@debasishbsws) | |||
| * [CHANGE] **BREAKING CHANGE** Bump tempo-query dependency to Jaeger 1.58.1 and switch from grpcPlugin to standalone server [#3840](https://github.com/grafana/tempo/issues/3840) (@frzifus) | |||
There was a problem hiding this comment.
How is this breaking change surfaced to users? What do they need to do?
Does the configuration of tempo-query change?
There was a problem hiding this comment.
The configuration should be the same. The main change is that Jaeger is no longer part of the resulting image.
Instead of configuring the plugin with Jaeger a user needs to configure Jaeger itself to use the tempo-query proxy as storage backend.
frzifus
force-pushed
the
bump/tempo-query
branch
2 times, most recently
from
90f8e55
to
157091e
Compare
Jaeger 1.58 no longer supports gRPC storage plugins. Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR replaces the tempo-query gRPC storage plugin due to the deprecation in Jaeger 1.58.0 with a gRPC standalone service.
Instead of
jaeger+tempo storage plugin, only thejaeger remote storage proxyis now delivered. This can be deployed as a sidecar to jaeger to achieve the same behavior again.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]