Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable an instance of tezossigner to deploy a contract using FF core API #298

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Mar 20, 2024

Related PRs to firefly and firefly-tezosconnect

Signed-off-by: Alexey Semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: Alexey Semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: Alexey Semenyuk <alexsemenyuk88@gmail.com>
@nguyer
Copy link
Contributor

nguyer commented Apr 8, 2024

Hey @alex-semenyuk I'm happy to include this, but I'm unclear on how someone would use this command with these changes. Do you also need to add a ff deploy tezos sub command?

@alex-semenyuk
Copy link
Member Author

Hey @alex-semenyuk I'm happy to include this, but I'm unclear on how someone would use this command with these changes. Do you also need to add a ff deploy tezos sub command?

Hey @nguyer
As I mentioned at description it's required for new implemented deploy API. We need to add 'origination' as allowed transaction value for the given address config Originating means the same as Deploying contract

@nguyer
Copy link
Contributor

nguyer commented Apr 8, 2024

Okay so this is just making the change to enable an instance of tezossigner to deploy a contract that is created by the FireFly CLI? And we could have separate PR later to allow the user to actually deploy a contract with the FireFly CLI?

@denisandreenko
Copy link
Member

@nguyer you're right.
It unblocks tezossigner for a contract deployment, so we can use FF core API to make a deployment request.
CLI support will be added next.

@alex-semenyuk alex-semenyuk changed the title DeployContract implementation for Tezos connector Enable an instance of tezossigner to deploy a contract using FF core API Apr 9, 2024
@alex-semenyuk
Copy link
Member Author

alex-semenyuk commented Apr 9, 2024

@nguyer @denisandreenko Thanks!
Changed the name of this PR to avoid confusion. Also going to add support deploying via CLI in the next iterations/PRs.

@nguyer nguyer merged commit a6a55a9 into hyperledger:main Apr 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants