make sure to add ipv4 of host before ipv6 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing ticket_status which can not be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
On a node that has a dual stack connection, with ipv6 being the first, and with defined v4 slaves, you end up having v4 ns1 and ns2 as slaves and a v6 ns1 that points to the i-MSCP node.
Intended fix:
Get the v4 IP from BASE_SERVER_PUBLIC_IP if the main DOMAIN_IP is v6 and then add the v6 ip immediately after the v4 one.
This should provide us with a final dns alike: