Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19 - CodexiaModule: transforming sendReview to saveReview && extracting SendReviews cron #38

Merged
merged 7 commits into from
Apr 17, 2020

Conversation

iakunin
Copy link
Owner

@iakunin iakunin commented Apr 16, 2020

This PR is for issue #19

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #38 into master will increase coverage by 2.38%.
The diff coverage is 88.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage     33.23%   35.62%   +2.38%     
- Complexity       81       88       +7     
============================================
  Files            42       43       +1     
  Lines           686      699      +13     
  Branches         19       19              
============================================
+ Hits            228      249      +21     
+ Misses          452      445       -7     
+ Partials          6        5       -1     
Impacted Files Coverage Δ Complexity Δ
.../dev/iakunin/codexiabot/bot/FoundOnHackernews.java 3.92% <0.00%> (ø) 1.00 <0.00> (ø)
...java/dev/iakunin/codexiabot/bot/FoundOnReddit.java 4.76% <0.00%> (ø) 1.00 <0.00> (ø)
...odexiabot/codexia/cron/ResendErroneousReviews.java 14.28% <0.00%> (ø) 1.00 <0.00> (ø)
...ev/iakunin/codexiabot/github/cron/stat/Github.java 7.69% <0.00%> (ø) 1.00 <0.00> (ø)
...v/iakunin/codexiabot/codexia/cron/SendReviews.java 97.22% <97.22%> (ø) 7.00 <7.00> (?)
.../main/java/dev/iakunin/codexiabot/bot/StarsUp.java 95.16% <100.00%> (ø) 15.00 <0.00> (ø)
.../iakunin/codexiabot/codexia/CodexiaModuleImpl.java 85.71% <100.00%> (+12.98%) 7.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ad97f...61d65bf. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

89.4% 89.4% Coverage
0.0% 0.0% Duplication

@iakunin iakunin merged commit c743679 into master Apr 17, 2020
@iakunin iakunin deleted the 19 branch April 17, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant