Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the way we do environment variables in local.zeek #413

Closed
mmguero opened this issue Feb 15, 2024 · 0 comments
Closed

fix the way we do environment variables in local.zeek #413

mmguero opened this issue Feb 15, 2024 · 0 comments
Assignees
@mmguero
Labels
bug Something isn't working zeek Relating to Malcolm's use of Zeek
Milestone
v24.03.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Feb 15, 2024

This is how local.zeek reads "boolean" environment variables.

This is dumb, because a blank/empty string is the only thing that means "false." If the user puts the string false, it ends up as true. At the very least we should do blank/empty is false and also the string false.
@mmguero mmguero added bug Something isn't working zeek Relating to Malcolm's use of Zeek labels Feb 15, 2024
@mmguero mmguero added this to the v24.03.0 milestone Feb 15, 2024
@mmguero mmguero self-assigned this Feb 16, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Feb 16, 2024
@mmguero
fix the way we do environment variables in local.zeek (close idaholab…
58f74b2 
…#413)
@mmguero mmguero closed this as completed Feb 16, 2024
This was referenced Mar 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
bug Something isn't working zeek Relating to Malcolm's use of Zeek
Projects
Malcolm
Status: Released
Milestone
v24.03.0
Development

No branches or pull requests
1 participant
@mmguero