Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2792: Improve cache usage reporting #92

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Feb 8, 2024

Clustered Caches should report their actual size, TTL and units used, instead of defaulting to the properties that define non-clustered caches.

See https://igniterealtime.atlassian.net/browse/OF-2792 for a detailed description of the problems addressed by this commit.

This commit assumes that the corresponding Openfire fix for OF-2792 are merged into and released as Openfire 4.8.1.

This is a screenshot of the changes in this PR that are combined with the corresponding Openfire changes:

image

@guusdk
Copy link
Member Author

guusdk commented Feb 8, 2024

The build of this PR will fail until Openfire 4.8.1 is available that has the corresponding changes for Openfire.

Copy link
Contributor

@GregDThomas GregDThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Clustered Caches should report their actual size, TTL and units used, instead of defaulting to the properties that define non-clustered caches.

See https://igniterealtime.atlassian.net/browse/OF-2792 for a detailed description of the problems addressed by this commit.

This commit assumes that the corresponding Openfire fix for OF-2792 are merged into and released as Openfire 4.8.1.
@Fishbowler Fishbowler force-pushed the OF-2792_Admin-console-Cache-Summary-reporting branch from ffe3453 to e1b57d7 Compare March 9, 2024 16:42
@Fishbowler
Copy link
Member

Pushed a 1 char change to kick the GHA checks back to life

@Fishbowler Fishbowler merged commit f04bc3f into igniterealtime:main Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants