trails_handler supports parameter

[turtleDeng]

cowboy_trails is a great project.
trails_handler support parameters will be a very good feature.

https://github.com/inaka/cowboy_swagger/blob/master/src/cowboy_swagger_json_handler.erl#L31

[elbrujohalcon]

Not a bad idea, but I guess it requires many more changes than the ones you just submitted, right?

[turtleDeng]

This is a compatibility modification
Support the use

trails:trails([{cowboy_swagger_handler, #{server => xxx}}]) and
trails:trails([cowboy_swagger_handler])

[turtleDeng]

Our project will listen to multiple http ports, and their APIs are different, trails: trails does not support parameters will cause me to be unable to open swaggerUI

[elbrujohalcon]

Sorry, @turtleDeng … But you'll have to be a bit more detailed than that.
On one hand, I kinda see what you're aiming to achieve… but on the other hand your PR seems to imply that the rest of the code in this project already supports that and I have no compelling reason to think that's true.

[elbrujohalcon]

Our project will listen to multiple http ports, and their APIs are different, trails: trails does not support parameters will cause me to be unable to open swaggerUI

I see… and just by changing that single line in trails_handler you make it work? That's what seems odd to me. Don't you need to change other stuff in the project to add support for it?

[elbrujohalcon]

You, at the very least, need to add a new callback to trails_handler. And probably make it optional, I think.

[turtleDeng]

Yes, add a trails/1 callback

[elbrujohalcon]

Great! Now, can you please do the following things?

• make the new callback optional (as a matter of fact, you'll probably like both callbacks to be optional now… so you can implement just one of them).
• add some tests to trails_SUITE for this new feature
• adjust the documentation for trails_handler callbacks in the README

[elbrujohalcon]

Two additional small changes and we're done.

[elbrujohalcon]

Well… now we have some dialyzer issue in our hands… 🤔