Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method field to trails #20

Merged
merged 8 commits into from
Jun 29, 2015
Merged

Add a method field to trails #20

merged 8 commits into from
Jun 29, 2015

Conversation

davecaos
Copy link
Contributor

Fix #10 issue.

@elbrujohalcon elbrujohalcon self-assigned this Jun 29, 2015
@gadgetci
Copy link
Member

According to Elvis:

Dependency 'cowlib' is not using appropriate protocol, please change this to something like 'git://.*'

@gadgetci
Copy link
Member

According to Elvis:

Dependency 'ranch' is not using appropriate protocol, please change this to something like 'git://.*'

elbrujohalcon
elbrujohalcon reviewed Jun 29, 2015
View reviewed changes
src/trails.erl
}.
-export_type([trail/0]).

-type trails() :: [ trails:trail() | cowboy_router:route_path() ].
%% exported from cowboy_router.erl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not exported ;)

elbrujohalcon pushed a commit that referenced this pull request Jun 29, 2015
Merge pull request #20 from inaka/dave.10.Add_Metadata_fields
9e72931 
Add a method field to trails
@elbrujohalcon elbrujohalcon merged commit 9e72931 into master Jun 29, 2015
@davecaos davecaos deleted the dave.10.Add_Metadata_fields branch June 29, 2015 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elbrujohalcon elbrujohalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davecaos @gadgetci @elbrujohalcon