Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some dep.s for OTP 24 compatibility #97

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Bump some dep.s for OTP 24 compatibility #97

merged 3 commits into from
Mar 25, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Mar 23, 2021

  • rebar3_lint brings improvements in linting
  • meck drops hamcrest (one less dep. to deal with)
  • mixer is up'ed for no practical reason compatibility with OTP 24 (as per pull request there)

Had this pending here from my OTP-24 tests.

  • wait for elvis_core (post 1.1.1) + rebar3_lint (post 0.3.2) to be released
  • ct's failing (it was a local thing)

`rebar3_lint` brings improvements in linting
`meck` drops `hamcrest` (one less dep. to deal with)
`mixer` is up'ed for no practical reason
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft March 23, 2021 13:47
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Hm... there's still warnings... lemme check this real quick.

We have no Makefile present
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Bump some dep.s Bump some dep.s for OTP 24 compatibility Mar 23, 2021
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review March 24, 2021 17:41
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Moving away from draft, since pre-conditions are attained. I'm good for merge after you accept the content and CI is happy.

@elbrujohalcon elbrujohalcon merged commit 97cd765 into inaka:master Mar 25, 2021
@elbrujohalcon
Copy link
Member

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Great. Thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/approach-otp-24 branch March 26, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants