Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is not elvis:webhook/1 function anymore so please update the documentation #322

Closed
harenson opened this issue Jan 7, 2016 · 4 comments
Closed

There is not elvis:webhook/1 function anymore so please update the documentation #322

harenson opened this issue Jan 7, 2016 · 4 comments
Labels
hacktoberfest

Comments

@harenson
Copy link
Member

harenson commented Jan 7, 2016

Outdated documentation references elvis:webhook/1: https://github.com/inaka/elvis#running-the-webhook-on-your-servers
@JohanVikman
Copy link
Contributor

How do you want this fixed? Is the webhook functionality removed altogether?

@jfacorro
Copy link
Contributor

jfacorro commented Oct 2, 2017

@JohanVikman The webhook functionality is there, but it seems the service is no longer working http://elvis.inakalabs.com/.

@harenson
Copy link
Member Author

harenson commented Oct 2, 2017

@JohanVikman @jfacorro Yes, the functionality is still there, but the function webhook with arity 1 within the elvis module doesn't exist anymore. The aim of this issue is to update the documentation by pointing to the new implementation of this functionality which if I recall correctly would be calling elvis_webhook:event/1 instead.

JohanVikman added a commit to JohanVikman/elvis that referenced this issue Oct 3, 2017
@JohanVikman
[inaka#322] Fix webhook readme instructions
dea9d6b
@JohanVikman
Copy link
Contributor

Created a PR

elbrujohalcon added a commit that referenced this issue Oct 3, 2017
@elbrujohalcon
Merge pull request #474 from JohanVikman/jowi.322.remove_webhook
8a887fe 
[#322] Fix webhook readme instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elbrujohalcon @harenson @JohanVikman @jfacorro