Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update lager #385

Closed
deadtrickster opened this issue Jul 24, 2016 · 4 comments
Closed

Please update lager #385

deadtrickster opened this issue Jul 24, 2016 · 4 comments

Comments

@deadtrickster
Copy link

Looks like lager version is a bit outdated and elvis fails to compile on otp19.

see https://github.com/basho/lager/pull/321

@elbrujohalcon
Copy link
Member

@deadtrickster would you mind sending a PR with the change?

deadtrickster added a commit to deadtrickster/elvis_core that referenced this issue Jul 25, 2016
@deadtrickster
Copy link
Author

@elbrujohalcon I noticed lager in elvis_core outdated too (and lager is used by elvis_core not by elvis itself). I made branch with fix - https://github.com/deadtrickster/elvis_core/tree/update-deps.
However looks like lager still should be explicitly listed as dependency in elvis because lots of other libs use outdated versions too.
Question: should I leave elvis_core as is and just update lager in elvis, or maybe submit pr to elvis_core first and then submit pr here with update lager and elvis_core ref?

@elbrujohalcon
Copy link
Member

@deadtrickster I think it's already fixed in the latest release of elvis_core. It will be fixed here, too once @Euen gets to rebarize this project.

@deadtrickster
Copy link
Author

Yea, elvis_core master now compiles, so I guess I'm closing this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants